Online DDL/VReplication: support DROP+ADD column of same name #8337
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It is valid (though not good practice, probably) to
DROP
a columnc
andADD
a new column also calledc
. In this scenario, the columnc
in the before table has nothing to do withc
in the after table.In this PR we import logic from
gh-ost
to make sure Vreplication does not try to copy data between such column.We add the test
drop-null-add-not-null
to OnlineDDL/vrpelication suite.Related Issue(s)
Checklist